Skip to content

Fix volume response for service offering with disk offering#9273

Merged
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:fix-serviceoffering-check
Jun 22, 2024
Merged

Fix volume response for service offering with disk offering#9273
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:fix-serviceoffering-check

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Jun 20, 2024 •
edited
Loading

Description

This PR fixes the bug introduced in #9235 . This resulted in volume response not having diskofferingid in the response for a service offering with a disk offering.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Copy Markdown
Member Author

vishesh92 commented Jun 20, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2024

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92 vishesh92 requested a review from DaanHoogland June 20, 2024 08:48
DaanHoogland
DaanHoogland approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

sureshanaparti
sureshanaparti approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.42%. Comparing base (84b91cc) to head (75e77c7).
Report is 1 commits behind head on 4.19.

Files Patch % Lines
...ava/com/cloud/api/query/dao/VolumeJoinDaoImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9273      +/-   ##
============================================
+ Coverage     14.95%   15.42%   +0.46%     
- Complexity    11014    11811     +797     
============================================
  Files          5382     5469      +87     
  Lines        470092   478292    +8200     
  Branches      59650    61056    +1406     
============================================
+ Hits          70308    73775    +3467     
- Misses       391996   396389    +4393     
- Partials       7788     8128     +340
Flag Coverage Δ
uitests 4.18% <ø> (-0.10%) ⬇️
unittests 16.18% <0.00%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 changed the base branch from main to 4.19 June 20, 2024 09:03
@vishesh92
Copy link
Copy Markdown
Member Author

vishesh92 commented Jun 20, 2024

@blueorangutan package

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Jun 20, 2024
weizhouapache
weizhouapache approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 20, 2024

@blueorangutan test

@apache apache deleted a comment from blueorangutan Jun 20, 2024
@apache apache deleted a comment from blueorangutan Jun 20, 2024
@apache apache deleted a comment from blueorangutan Jun 20, 2024
@apache apache deleted a comment from blueorangutan Jun 20, 2024
@apache apache deleted a comment from blueorangutan Jun 20, 2024
@apache apache deleted a comment from blueorangutan Jun 20, 2024
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2024

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10037

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jun 20, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2024

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2024

[SF] Trillian Build Failed (tid-10536)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 21, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 21, 2024

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 22, 2024

[SF] Trillian test result (tid-10547)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51002 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9273-t10547-kvm-centos7.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@sureshanaparti sureshanaparti merged commit 59e9ab9 into apache:4.19 Jun 22, 2024
@DaanHoogland DaanHoogland deleted the fix-serviceoffering-check branch June 24, 2024 18:44
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
@vishesh92 @dhslove
Fix volume response for service offering with disk offering (apache#9273
b24df25 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@vishesh92 @blueorangutan @sureshanaparti @weizhouapache @yadvr @DaanHoogland